Skip to content

Add tests #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 2, 2018
Merged

Add tests #341

merged 5 commits into from
Feb 2, 2018

Conversation

urbandove
Copy link
Contributor

Added a few tests

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 92.835% when pulling 65e6302 on urbandove:tests into 24706f5 on graphql-python:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 92.835% when pulling 65e6302 on urbandove:tests into 24706f5 on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 92.835% when pulling 65e6302 on urbandove:tests into 24706f5 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 12, 2017

Coverage Status

Coverage decreased (-0.2%) to 92.938% when pulling de59d26 on urbandove:tests into 24706f5 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 92.938% when pulling de59d26 on urbandove:tests into 24706f5 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 12, 2017

Coverage Status

Coverage decreased (-0.1%) to 93.04% when pulling 29935c2 on urbandove:tests into 24706f5 on graphql-python:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.04% when pulling 29935c2 on urbandove:tests into 24706f5 on graphql-python:master.

@coveralls
Copy link

coveralls commented Dec 12, 2017

Coverage Status

Coverage increased (+0.6%) to 93.756% when pulling 51f794e on urbandove:tests into 24706f5 on graphql-python:master.

@spockNinja
Copy link
Contributor

@urbandove Thanks for the test additions! We're waiting on another test fix to get the build passing again. Once that is merged, we can re-run this through Travis.

@spockNinja
Copy link
Contributor

@urbandove
Tests are all passing. Coverage is up a bit. Thanks for the contribution!

@syrusakbary
Here are some test additions with one minor fix found in the test_should_error_if_last_is_greater_than_max test that appears to remedy some copy-pasta. It's ready for your stamp of approval.

@patrick91
Copy link
Member

@graphql-python/django can we merge this? :)

@syrusakbary syrusakbary merged commit fd3faf0 into graphql-python:master Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants